Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(java_templates): group guava with other core dependencies #392

Merged
merged 1 commit into from Jan 30, 2020
Merged

fix(java_templates): group guava with other core dependencies #392

merged 1 commit into from Jan 30, 2020

Conversation

chingor13
Copy link
Contributor

Guava usually needs to be bumped alongside many other dependencies. Without group them, the individual PRs will fail dependency upper bounds checks

Example of grouped PR: googleapis/java-webrisk#46

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2020
@bcoe bcoe merged commit f9e3105 into master Jan 30, 2020
@chingor13 chingor13 deleted the chingor13-patch-1 branch February 24, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@SurferJeffAtGoogle SurferJeffAtGoogle Awaiting requested review from SurferJeffAtGoogle

@BenWhitehead BenWhitehead Awaiting requested review from BenWhitehead

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chingor13 @bcoe @googlebot