Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add libraries_bom_version in metadata #1956

Merged
merged 9 commits into from Apr 15, 2024
Merged

feat: add libraries_bom_version in metadata #1956

merged 9 commits into from Apr 15, 2024

Conversation

JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Apr 15, 2024 •
edited

In this PR:

  • Add a libraries_bom_version when rending README.md. It will fall back to latest_bom_version if this parameter is not set.

@JoeWang1127
Copy link
Contributor Author

These lines prevent me to write a unit test running in kokoro.

# skip README generation on Kokoro (autosynth)
    if os.environ.get("KOKORO_ROOT") is not None:
        # README.md is now synthesized separately. This prevents synthtool from deleting the
        # README as it's no longer generated here.
        excludes.append("README.md")

@JoeWang1127 JoeWang1127 marked this pull request as ready for review April 15, 2024 19:52
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner April 15, 2024 19:52
@JoeWang1127 JoeWang1127 mentioned this pull request Apr 15, 2024
Merged
@JoeWang1127 JoeWang1127 merged commit 63cc541 into master Apr 15, 2024
12 checks passed
@JoeWang1127 JoeWang1127 deleted the feat/add-libraries-bom-version branch April 15, 2024 22:36
JoeWang1127 added a commit to googleapis/sdk-platform-java that referenced this pull request Apr 16, 2024
@JoeWang1127
feat: add libraries_bom_version to generation configuration (#2639)
56c7ca5 
In this PR:
- Add `libraries_bom_version` as a required parameter in generation
config.

The integration test is verified using a feature branch of synthtool:
googleapis/synthtool#1956.

The synthtool commit in integration test is changed to
`63cc541da2c45fcfca2136c43e638da1fbae174d` after the above feature
branch is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@diegomarquezp diegomarquezp Awaiting requested review from diegomarquezp

Assignees

@chingor13 chingor13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoeWang1127 @blakeli0 @chingor13