Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): include UPGRADING.rst if it exists #1285

Merged
merged 1 commit into from Nov 22, 2021

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 18, 2021

In googleapis/python-datacatalog#153 we discovered that Markdown does not support certain formatting options, like tables when rendered from Sphinx.

@tswast tswast requested a review from a team November 18, 2021 22:12
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2021
@tswast
Copy link
Contributor Author

tswast commented Nov 18, 2021

Without this change, Owlbot reverts the UPGRADING guide section, breaking the docs build: googleapis/python-datacatalog@f5c771b

@tswast tswast merged commit d05118d into master Nov 22, 2021
@tswast tswast deleted the datacatalog153-upgrading-rst branch November 22, 2021 15:23
@tswast
Copy link
Contributor Author

tswast commented Dec 1, 2021

@parthea Owlbot keeps reverting the "MIgration" section in googleapis/python-datacatalog#268 Do we know when these templates become available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants