fix: turn off obsolete file tracking by default (#391)

* fix: turn off obsolete file tracking by default Fixes #390 The file system's timestamps are not reliably, there is no way synth.py should have ever ended up in the list of generated files, as happened here: https://github.com/googleapis/nodejs-datalabeling/blob/master/synth.metadata * Rename test to test_track_obselete_files_defaults_to_false.
googleapis · Jan 30, 2020 · c2c8465 · c2c8465
1 parent 965fe83
commit c2c8465
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/synthtool/metadata.py b/synthtool/metadata.py
@@ -30,7 +30,7 @@
 
 
 _metadata = metadata_pb2.Metadata()
-_track_obsolete_files = True
+_track_obsolete_files = False
 
 
 def reset() -> None:

diff --git a/tests/test_metadata.py b/tests/test_metadata.py
@@ -262,8 +262,8 @@ def preserve_track_obsolete_file_flag():
     metadata.set_track_obsolete_files(should_track_obselete_files)
 
 
-def test_track_obsolete_files_defaults_to_true(preserve_track_obsolete_file_flag):
-    assert metadata.should_track_obsolete_files()
+def test_track_obsolete_files_defaults_to_false(preserve_track_obsolete_file_flag):
+    assert not metadata.should_track_obsolete_files()
 
 
 def test_set_track_obsolete_files(preserve_track_obsolete_file_flag):