feat: add a github client #2747
Conversation
| <version>3.2.5</version> | ||
| <configuration> | ||
| <environmentVariables> | ||
| <GITHUB_TOKEN>fake_value</GITHUB_TOKEN> |
There was a problem hiding this comment.
Add source code comment how it helps tests.
| import java.util.List; | ||
| import java.util.Objects; | ||
|
|
||
| public class GitHubClient { |
| @@ -29,7 +29,7 @@ | |||
| public class DepsDevClient { | |||
| @@ -0,0 +1,5 @@ | |||
| package com.google.cloud.model; | |||
|
|
|||
| public record PullRequestStatus(long created, long merged, Interval interval) { | |||
There was a problem hiding this comment.
Can you add Javadoc, especially which part of the dependency report this helps, with an example value.
There was a problem hiding this comment.
We can change the class name to PullRequestStatistics.
product-auto-label
bot
added
size: l
There was a problem hiding this comment.
Can you run the google-java-format formatter?
git diff -U0 origin/main |google-java-format-diff.py -p1 -i
The formatter does not merge multiple lines. Ensure you read the formatted files.
| * GitHubClient is a class that sends HTTP requests to the GitHub RESTful API. | ||
| * It provides methods for interacting with various GitHub resources such as repositories, | ||
| * issues, users, etc. | ||
| * <p> |
There was a problem hiding this comment.
New line before <p>. No new line after <p>. https://google.github.io/styleguide/javaguide.html#s7.1.2-javadoc-paragraphs
There was a problem hiding this comment.
I formatted the code using
git diff -U0 origin/main | python google-java-format-diff.py -p1 -i
|
|
In this PR: - Add a github client to retrieve pull request status from a repository. - Add unit test.
In this PR: - Add a github client to retrieve pull request status from a repository. - Add unit test.
In this PR: