Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add comment to service client to disclose api version. #2687

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Apr 24, 2024

Follow-up to #2630 #2671.

This pr adds to service client composer to expose api-version via class comment.

Note: reverted api-version option in gapic-generator-java/src/test/proto/echo_grpcrest.proto, which was added by accident in #2671. All test related to api-version should use api_version_testing.proto instead.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 24, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: s Pull request size is small. labels May 6, 2024
Copy link

sonarcloud bot commented May 6, 2024

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zhumin8 zhumin8 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
@zhumin8 zhumin8 changed the title [DRAFT] feat: add comment to service client to disclose api version. feat: add comment to service client to disclose api version. May 6, 2024
@zhumin8 zhumin8 requested a review from lqiu96 May 6, 2024 06:56
@zhumin8 zhumin8 marked this pull request as ready for review May 6, 2024 07:09
@zhumin8 zhumin8 requested a review from a team as a code owner May 6, 2024 07:09
Copy link

snippet-bot bot commented May 6, 2024

Here is the summary of possible violations 😱

There are 12 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 12 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant