resolve comments

googleapis · Aug 17, 2021 · de1a639 · de1a639
1 parent 439dcf2
commit de1a639
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.../google/api/generator/gapic/composer/common/AbstractServiceStubSettingsClassComposer.java b/.../google/api/generator/gapic/composer/common/AbstractServiceStubSettingsClassComposer.java
@@ -137,10 +137,6 @@ public abstract class AbstractServiceStubSettingsClassComposer implements ClassC
 
   private static final String DOT = ".";
 
-  protected static final TypeStore FIXED_TYPESTORE = createStaticTypes();
-
-  protected static final VariableExpr DEFAULT_SERVICE_SCOPES_VAR_EXPR =
-      createDefaultServiceScopesVarExpr();
   private static final VariableExpr NESTED_UNARY_METHOD_SETTINGS_BUILDERS_VAR_EXPR =
       createNestedUnaryMethodSettingsBuildersVarExpr();
   private static final VariableExpr NESTED_RETRYABLE_CODE_DEFINITIONS_VAR_EXPR =
@@ -150,6 +146,11 @@ public abstract class AbstractServiceStubSettingsClassComposer implements ClassC
 
   private final TransportContext transportContext;
 
+  protected static final TypeStore FIXED_TYPESTORE = createStaticTypes();
+
+  protected static final VariableExpr DEFAULT_SERVICE_SCOPES_VAR_EXPR =
+      createDefaultServiceScopesVarExpr();
+
   protected AbstractServiceStubSettingsClassComposer(TransportContext transportContext) {
     this.transportContext = transportContext;
   }

diff --git a/...n/java/com/google/api/generator/gapic/composer/grpc/ServiceStubSettingsClassComposer.java b/...n/java/com/google/api/generator/gapic/composer/grpc/ServiceStubSettingsClassComposer.java
@@ -113,6 +113,9 @@ protected MethodDefinition createDefaultCredentialsProviderBuilderMethod() {
             .setArguments(DEFAULT_SERVICE_SCOPES_VAR_EXPR)
             .setReturnType(returnType)
             .build();
+
+    // This section is specific to GAPIC clients. It sets UseJwtAccessWithScope value to true to
+    // enable self signed JWT feature.
     credsProviderBuilderExpr =
         MethodInvocationExpr.builder()
             .setExprReferenceExpr(credsProviderBuilderExpr)
@@ -122,6 +125,7 @@ protected MethodDefinition createDefaultCredentialsProviderBuilderMethod() {
                     PrimitiveValue.builder().setType(TypeNode.BOOLEAN).setValue("true").build()))
             .setReturnType(returnType)
             .build();
+
     return MethodDefinition.builder()
         .setHeaderCommentStatements(
             SettingsCommentComposer.DEFAULT_CREDENTIALS_PROVIDER_BUILDER_METHOD_COMMENT)