Skip to content

Commit

Permalink
fix: build_gen use lro gapic as lro dep (#3215)
Browse files Browse the repository at this point in the history
  • Loading branch information
noahdietz committed Jun 2, 2020
1 parent d433cc0 commit fab708c
Showing 1 changed file with 1 addition and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -233,16 +233,9 @@ private Set<String> mapGoGapicDeps(Set<String> protoImports) {
}

if (protoImport.endsWith(":operations_proto")) {
// Disable injection of unused longrunning GAPIC target as dependency.
//
// TODO(ndietz) enable this dependency once issue is closed:
// https://github.com/googleapis/gapic-generator-go/issues/387
// goImports.add(replaceLabelName(protoImport, ":longrunning_go_gapic"));
goImports.add(replaceLabelName(protoImport, ":longrunning_go_gapic"));
goImports.add(replaceLabelName(protoImport, ":longrunning_go_proto"));
goImports.add("@com_google_cloud_go//longrunning:go_default_library");
// TODO(ndietz) remove this dependency once issue is closed:
// https://github.com/googleapis/gapic-generator-go/issues/387
goImports.add("@com_google_cloud_go//longrunning/autogen:go_default_library");
for (String pi : protoImports) {
if (pi.startsWith("@com_google_protobuf//")) {
if (pi.endsWith(":struct_proto")) {
Expand Down

0 comments on commit fab708c

Please sign in to comment.