Skip to content

Commit

Permalink
feat: add DIREGAPIC support for PHP (#3305)
Browse files Browse the repository at this point in the history
  • Loading branch information
bshaffer committed Dec 8, 2020
1 parent 4e92a9b commit c38caeb
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions php/php_gapic.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ _php_gapic_postprocessed_srcjar = rule(
},
)

def php_gapic_srcjar(name, src, gapic_yaml, service_yaml, package, grpc_service_config = None, **kwargs):
def php_gapic_srcjar(name, src, gapic_yaml, service_yaml, package, grpc_service_config = None, transport = None, **kwargs):
raw_srcjar_name = "%s_raw" % name

gapic_srcjar(
Expand All @@ -128,6 +128,7 @@ def php_gapic_srcjar(name, src, gapic_yaml, service_yaml, package, grpc_service_
language = "php",
package = package,
grpc_service_config = grpc_service_config,
transport = transport,
**kwargs
)

Expand All @@ -137,7 +138,7 @@ def php_gapic_srcjar(name, src, gapic_yaml, service_yaml, package, grpc_service_
**kwargs
)

def php_gapic_library(name, src, gapic_yaml, service_yaml, package = None, deps = [], grpc_service_config = None, **kwargs):
def php_gapic_library(name, src, gapic_yaml, service_yaml, package = None, deps = [], grpc_service_config = None, transport = None, **kwargs):
srcjar_name = "%s_srcjar" % name

php_gapic_srcjar(
Expand All @@ -147,6 +148,7 @@ def php_gapic_library(name, src, gapic_yaml, service_yaml, package = None, deps
service_yaml = service_yaml,
package = package,
grpc_service_config = grpc_service_config,
transport = transport,
**kwargs
)

Expand Down

0 comments on commit c38caeb

Please sign in to comment.