Support multiple stable release branches / consider all branches when looking for previous release shas #2203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2202 馃
We are currently using this fork for our release process and it appears to be working as expected, but I'm sure there are edge cases that aren't being addressed yet.
This PR add a flag
--consider-all-branches
that, when specified, will use GitHub's compare commits API to compare the commits between head of the branch being released, and the found sha of the previous release, allowing the previous release's sha to be on a different branch. This allows, for example, to have a branch likerelease-1.7.x
, with the latest release being, say,1.7.4
, and then release a new minor version (1.8.0
) from a branch likerelease-1.8.x
, and have it correctly show the changelog of commits since1.7.4
, even though that tag is on a different branch.This PR isn't complete yet, and there's a lot of test coverage missing, but I wanted to get consensus on the approach before investing more time. Thanks!