fix(manifest): node-workspace plugin respects release-as #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prior to this change the node-workspace plugin would hard-code a patch version increment for any package whose only reason for receiving a version bump was because workspace dependencies updated. However, if that package has the release-as knob on, then that value should be used for the version.
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #901 +/- ##
=======================================
Coverage 94.43% 94.43%
=======================================
Files 73 73
Lines 9822 9835 +13
Branches 1044 1047 +3
=======================================
+ Hits 9275 9288 +13
Misses 543 543
Partials 4 4
Continue to review full report at Codecov.
|
chingor13
approved these changes
May 11, 2021
chingor13
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 11, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [11.12.0](https://www.github.com/googleapis/release-please/compare/v11.11.0...v11.12.0) (2021-05-11) ### Features * allow overriding release label ([#900](https://www.github.com/googleapis/release-please/issues/900)) ([1af2623](https://www.github.com/googleapis/release-please/commit/1af26231857509244935034d68e3d031f2dbbebd)) ### Bug Fixes * **manifest:** node-workspace plugin respects release-as ([#901](https://www.github.com/googleapis/release-please/issues/901)) ([2d4ee9e](https://www.github.com/googleapis/release-please/commit/2d4ee9eaed8efb96a0a42ce989d37325d1722eed)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.