feat: detect default branch #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
==========================================
+ Coverage 79.74% 79.79% +0.05%
==========================================
Files 40 40
Lines 4640 4657 +17
Branches 374 377 +3
==========================================
+ Hits 3700 3716 +16
- Misses 939 940 +1
Partials 1 1
Continue to review full report at Codecov.
|
This was referenced Jun 14, 2020
JustinBeckwith
approved these changes
Jun 14, 2020
src/graphql-to-commits.ts
Outdated
| @@ -124,7 +122,7 @@ async function graphqlToCommit( | |||
| let prEdge: PREdge = commitEdge.node.associatedPullRequests.edges[0]; | |||
|
|
|||
| // if the commit.sha and mergeCommit.oid do not match, assume that this | |||
| // was a push to master and drop the commit. | |||
| // was a push directl to the default branch. | |||
There was a problem hiding this comment.
typo in the comment
bcoe
force-pushed
the
detect-default-branch
branch
from
3eddaa4
to
c6306a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now programmatically detects default branch, making it easier to use an alternative.
This also should make it easier to support multiple release branches.
@feywind I expect this overlaps a bit with your work, but might make it a bit easier to see that work over the finish line 馃憣