-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic detection of default branch doesn't work for private repositories #474
Comments
@mateuszpodraza thank you for the bug report 👍 I could have sworn the client was authenticated during instantiation (I will need to dig into this). |
I ran into the same issue today. The same problem is failing our release-please gh action on private repos, and there's no such a way to use a workaround by specifying the default branch manually as there's no such input param in the action configuration. So, I dug deeper a bit and it seems that octokit expects headers in the |
Octokit seem to expect headers to be passed along with the repo and owner params. fixes googleapis#474
This bug is the only obstacle we have on the way of using release-please action in our team processes, so @bcoe I would appreciate if you could take a look at this PR soonish 🙏 |
While the fix is not released I came up with a fork that heals the bug — may be useful for somebody else who encountered the issue. One can use this action as for now: jobs:
release-please:
runs-on: ubuntu-latest
steps:
- uses: lancedikson/release-please-action@tmp-patch-release-please-version |
Octokit seem to expect headers to be passed along with the repo and owner params. fixes #474 Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Thanks @bcoe ! |
Environment details
release-please
version: 5.4.0Steps to reproduce
Trying from CLI is enough, although the same can be reproduced using a Github action
404 Not found
:When I've hooked a debugger into the process I noticed that the
GET /repos/:owner/:repo
call to Github's API does not have an authorisation header at all, but I didn't spend enough time looking through #468 to figure out why.There is a simple workaround - specifying the default brach manually allows release-please to continue.
The text was updated successfully, but these errors were encountered: