feat(node): update version number in package-lock.json #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
+ Coverage 79.79% 81.37% +1.58%
==========================================
Files 40 40
Lines 4657 4666 +9
Branches 377 382 +5
==========================================
+ Hits 3716 3797 +81
+ Misses 940 868 -72
Partials 1 1
Continue to review full report at Codecov.
|
|
@socsieng thanks for the contribution, happen to be doing some triage myself today and was excited to see this 😄 Will work on landing it early this week. |
bcoe
reviewed
Jun 14, 2020
socsieng
force-pushed
the
package-lock
branch
3 times, most recently
from
d6502cc
to
f488a35
Compare
Keep version number in package-lock.json in sync with package.json. Fixes: googleapis#464
bcoe
added
the
kokoro:force-run
bcoe
approved these changes
Jun 15, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep version number in package-lock.json in sync with package.json.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #464
I had some time to kill so I thought I would implement this PR despite the issue still being in triage. I know there is a chance that updating
package-lock.jsonisn't the desired behavior, but I did have some time to kill and understand if issue #464 and this PR are declined.