feat(node): update version number in package-lock.json

Keep version number in package-lock.json in sync with package.json. Fixes: #464
googleapis · Jun 15, 2020 · 00c2fb5 · 00c2fb5
1 parent 301a08a
commit 00c2fb5
Show file tree

Hide file tree

Showing 6 changed files with 436 additions and 0 deletions.
diff --git a/__snapshots__/node.js b/__snapshots__/node.js
@@ -0,0 +1,122 @@
+exports['papckage-lock-json-node-with'] = `
+{
+  "name": "node-test-repo",
+  "version": "0.123.5",
+  "lockfileVersion": 1,
+  "requires": true,
+  "dependencies": {}
+}
+
+`
+
+exports['CHANGELOG-node-message-no-package-lock'] = `
+created CHANGELOG.md [ci skip]
+`
+
+exports['CHANGELOG-node-no-package-lock'] = `
+# Changelog
+
+### [0.123.5](https://www.github.com/googleapis/node-test-repo/compare/v0.123.4...v0.123.5) 
+
+
+### Bug Fixes
+
+* **deps:** update dependency com.google.cloud:google-cloud-spanner to v1.50.0 ([1f9663c](https://www.github.com/googleapis/node-test-repo/commit/1f9663cf08ab1cf3b68d95dee4dc99b7c4aac373))
+* **deps:** update dependency com.google.cloud:google-cloud-storage to v1.120.0 ([fcd1c89](https://www.github.com/googleapis/node-test-repo/commit/fcd1c890dc1526f4d62ceedad561f498195c8939))
+
+`
+
+exports['package-json-node-message-no-package-lock'] = `
+updated package.json [ci skip]
+`
+
+exports['package-json-node-no-package-lock'] = `
+{
+  "name": "node-test-repo",
+  "version": "0.123.5",
+  "repository": {
+    "url": "git@github.com:samples/node-test-repo.git"
+  }
+}
+
+`
+
+exports['CHANGELOG-node-message-with-package-lock'] = `
+created CHANGELOG.md [ci skip]
+`
+
+exports['CHANGELOG-node-with-package-lock'] = `
+# Changelog
+
+### [0.123.5](https://www.github.com/googleapis/node-test-repo/compare/v0.123.4...v0.123.5) 
+
+
+### Bug Fixes
+
+* **deps:** update dependency com.google.cloud:google-cloud-spanner to v1.50.0 ([1f9663c](https://www.github.com/googleapis/node-test-repo/commit/1f9663cf08ab1cf3b68d95dee4dc99b7c4aac373))
+* **deps:** update dependency com.google.cloud:google-cloud-storage to v1.120.0 ([fcd1c89](https://www.github.com/googleapis/node-test-repo/commit/fcd1c890dc1526f4d62ceedad561f498195c8939))
+
+`
+
+exports['package-json-node-message-with-package-lock'] = `
+updated package.json [ci skip]
+`
+
+exports['package-json-node-with-package-lock'] = `
+{
+  "name": "node-test-repo",
+  "version": "0.123.5",
+  "repository": {
+    "url": "git@github.com:samples/node-test-repo.git"
+  }
+}
+
+`
+
+exports['package-lock-json-node-message'] = `
+updated package-lock.json [ci skip]
+`
+
+exports['PR body-node-no-package-lock'] = `
+:robot: I have created a release \\*beep\\* \\*boop\\* 
+---
+### [0.123.5](https://www.github.com/googleapis/node-test-repo/compare/v0.123.4...v0.123.5) 
+
+
+### Bug Fixes
+
+* **deps:** update dependency com.google.cloud:google-cloud-spanner to v1.50.0 ([1f9663c](https://www.github.com/googleapis/node-test-repo/commit/1f9663cf08ab1cf3b68d95dee4dc99b7c4aac373))
+* **deps:** update dependency com.google.cloud:google-cloud-storage to v1.120.0 ([fcd1c89](https://www.github.com/googleapis/node-test-repo/commit/fcd1c890dc1526f4d62ceedad561f498195c8939))
+---
+
+
+This PR was generated with [Release Please](https://github.com/googleapis/release-please).
+`
+
+exports['labels-node-no-package-lock'] = {
+  'labels': [
+    'autorelease: pending'
+  ]
+}
+
+exports['PR body-node-with-package-lock'] = `
+:robot: I have created a release \\*beep\\* \\*boop\\* 
+---
+### [0.123.5](https://www.github.com/googleapis/node-test-repo/compare/v0.123.4...v0.123.5) 
+
+
+### Bug Fixes
+
+* **deps:** update dependency com.google.cloud:google-cloud-spanner to v1.50.0 ([1f9663c](https://www.github.com/googleapis/node-test-repo/commit/1f9663cf08ab1cf3b68d95dee4dc99b7c4aac373))
+* **deps:** update dependency com.google.cloud:google-cloud-storage to v1.120.0 ([fcd1c89](https://www.github.com/googleapis/node-test-repo/commit/fcd1c890dc1526f4d62ceedad561f498195c8939))
+---
+
+
+This PR was generated with [Release Please](https://github.com/googleapis/release-please).
+`
+
+exports['labels-node-with-package-lock'] = {
+  'labels': [
+    'autorelease: pending'
+  ]
+}
diff --git a/src/releasers/node.ts b/src/releasers/node.ts
@@ -92,6 +92,15 @@ export class Node extends ReleasePR {
       })
     );
 
+    updates.push(
+      new PackageJson({
+        path: 'package-lock.json',
+        changelogEntry,
+        version: candidate.version,
+        packageName: this.packageName,
+      })
+    );
+
     updates.push(
       new SamplesPackageJson({
         path: 'samples/package.json',

diff --git a/test/releasers/fixtures/node/commits.json b/test/releasers/fixtures/node/commits.json
@@ -0,0 +1,97 @@
+{
+  "repository": {
+    "defaultBranchRef": {
+      "target": {
+        "history": {
+          "edges": [
+            {
+              "node": {
+                "message": "fix(deps): update dependency com.google.cloud:google-cloud-storage to v1.120.0",
+                "oid": "fcd1c890dc1526f4d62ceedad561f498195c8939",
+                "associatedPullRequests": {
+                  "edges": [
+                    {
+                      "node": {
+                        "mergeCommit": {
+                          "oid": "fcd1c890dc1526f4d62ceedad561f498195c8939"
+                        },
+                        "number": 292,
+                        "labels": {
+                          "edges": [
+                            {
+                              "node": {
+                                "name": "cla: yes"
+                              }
+                            }
+                          ]
+                        }
+                      }
+                    }
+                  ]
+                }
+              }
+            },
+            {
+              "node": {
+                "message": "fix(deps): update dependency com.google.cloud:google-cloud-spanner to v1.50.0",
+                "oid": "1f9663cf08ab1cf3b68d95dee4dc99b7c4aac373",
+                "associatedPullRequests": {
+                  "edges": [
+                    {
+                      "node": {
+                        "mergeCommit": {
+                          "oid": "1f9663cf08ab1cf3b68d95dee4dc99b7c4aac373"
+                        },
+                        "number": 301,
+                        "labels": {
+                          "edges": [
+                            {
+                              "node": {
+                                "name": "cla: yes"
+                              }
+                            }
+                          ]
+                        }
+                      }
+                    }
+                  ]
+                }
+              }
+            },
+            {
+              "node": {
+                "message": "chore: update common templates",
+                "oid": "3006009a2b1b2cb4bd5108c0f469c410759f3a6a",
+                "associatedPullRequests": {
+                  "edges": [
+                    {
+                      "node": {
+                        "mergeCommit": {
+                          "oid": "3006009a2b1b2cb4bd5108c0f469c410759f3a6a"
+                        },
+                        "number": 300,
+                        "labels": {
+                          "edges": [
+                            {
+                              "node": {
+                                "name": "cla: yes"
+                              }
+                            }
+                          ]
+                        }
+                      }
+                    }
+                  ]
+                }
+              }
+            }
+          ],
+          "pageInfo": {
+            "endCursor": "fcd1c890dc1526f4d62ceedad561f498195c8939 99",
+            "hasNextPage": false
+          }
+        }
+      }
+    }
+  }
+}
diff --git a/test/releasers/fixtures/node/package-lock.json b/test/releasers/fixtures/node/package-lock.json
diff --git a/test/releasers/fixtures/node/package.json b/test/releasers/fixtures/node/package.json
@@ -0,0 +1,7 @@
+{
+  "name": "node-test-repo",
+  "version": "0.123.4",
+  "repository": {
+    "url": "git@github.com:samples/node-test-repo.git"
+  }
+}