feat: introduce generic updater #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion with the generic updater
kalosisz
reviewed
Dec 22, 2021
| @@ -40,3 +40,27 @@ export class CompositeUpdater implements Updater { | |||
| return content || ''; | |||
| } | |||
| } | |||
|
|
|||
| export function mergeUpdates(updates: Update[]): Update[] { | |||
| const updatesByPath: Record<string, Update[]> = {}; | |||
There was a problem hiding this comment.
Would it make sense to have Record<Update['path'], Update[]>?
There was a problem hiding this comment.
That would probably work in case update's path's type changes, but I think for readability, string might be easier to read.
bcoe
reviewed
Dec 22, 2021
For the generic updater, this will be provided adhoc via the |
bcoe
suggested changes
Dec 23, 2021
Opened: #1174 to follow up with |
|
@bcoe Added documentation in docs/customizing.md |
bcoe
approved these changes
Dec 29, 2021
chingor13
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 29, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [13.1.0](https://www.github.com/googleapis/release-please/compare/v13.0.2...v13.1.0) (2021-12-29) ### Features * introduce generic updater ([#1157](https://www.github.com/googleapis/release-please/issues/1157)) ([c97598c](https://www.github.com/googleapis/release-please/commit/c97598c137b5018c76f5d62137e277b991f4bfa3)), closes [#435](https://www.github.com/googleapis/release-please/issues/435) [#305](https://www.github.com/googleapis/release-please/issues/305) [#1139](https://www.github.com/googleapis/release-please/issues/1139) [#1174](https://www.github.com/googleapis/release-please/issues/1174) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new
Genericupdater class that scans the file line by line for annotations.You can annotate a line (inline) via:
x-release-please-versionx-release-please-majorx-release-please-minorx-release-please-patchFor these annotations, we will try to replace the value on that line only.
You can annotate a block by starting with a line containing:
x-release-please-start-versionx-release-please-start-majorx-release-please-start-minorx-release-please-start-patchand close the block with a line containing
x-release-please-end. Within the block, we will attempt to replace version values.Additionally, all basic strategies now support the
extra-filesoption which will apply this generic updater class.Fixes #435
Fixes #305
Fixes #1139
Fixes #1174