This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
fix: update README for library conversion to microgenerator #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
busunkim96
suggested changes
Jul 14, 2020
README.rst
Outdated
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| Python == 2.7. | ||
|
|
||
| The last version of this library compatible with Python 2.7 is google-cloud-webrisk==1.0.0 |
There was a problem hiding this comment.
Suggested change
| The last version of this library compatible with Python 2.7 is google-cloud-webrisk==1.0.0 | |
| The last version of this library compatible with Python 2.7 is google-cloud-webrisk==0.3.0 |
There was a problem hiding this comment.
curious that in setup.py, the release version is 1.0.0, which one should we take here? Thanks
There was a problem hiding this comment.
@xiaozhenliu-gg5 The microgenerator code has been merged and released (as 1.0.0). #25 The previous version was 0.3.0
There was a problem hiding this comment.
👍 sounds reasonable.
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
busunkim96
approved these changes
Jul 14, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 15, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.0.1](https://www.github.com/googleapis/python-webrisk/compare/v1.0.0...v1.0.1) (2020-07-15) ### Bug Fixes * update README for library conversion to microgenerator ([#29](https://www.github.com/googleapis/python-webrisk/issues/29)) ([ebd278b](https://www.github.com/googleapis/python-webrisk/commit/ebd278b8c41d72a9f9c594677c8d69684d8ef977)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.