Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

test: update tests to support latest google-cloud-core #69

Merged
merged 5 commits into from Oct 6, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Sep 23, 2020

google-cloud-core version 1.4.2 populates prettyPrint=false by
default. Update the connection tests to expect a value for
prettyPrint.

test_build_api_url_w_extra_query_params_tuple unit test is currently failing, but will be fixed by googleapis/python-cloud-core#34

This pull request is to check that the changes made in googleapis/python-cloud-core#28 do not break this library.

`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.
@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 23, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2020
@product-auto-label product-auto-label bot added the api: translate Issues related to the googleapis/python-translate API. label Sep 24, 2020
@tswast tswast requested a review from a team as a code owner September 29, 2020 19:48
@tswast tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2020
@tseaver tseaver merged commit 2f96f2e into googleapis:master Oct 6, 2020
parthea pushed a commit that referenced this pull request Mar 12, 2022
`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.
parthea added a commit that referenced this pull request Apr 5, 2022
…353)

* chore(deps): allow google-api-core v2 on v2 release

* test: update tests to support latest google-cloud-core (#69)

`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.

* ci: fix docs build

* chore: lint

* Update setup.py

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore: format, revert changes to tests

Co-authored-by: Tim Swast <swast@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: translate Issues related to the googleapis/python-translate API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants