Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

docs: connect Python Translate client library to nebulous serverless example #162

Merged
merged 9 commits into from May 28, 2021

Conversation

wescpy
Copy link
Contributor

@wescpy wescpy commented May 22, 2021

Not adding new code but linking to another repo with a sample app using this API as another sample for users; added folder with README per @busunkim96

@wescpy wescpy requested a review from a team as a code owner May 22, 2021 00:10
@product-auto-label product-auto-label bot added the api: translate Issues related to the googleapis/python-translate API. label May 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 22, 2021
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wonder if we can increase the visibility of this by adding it to the README on the top directory. Not sure if that's a client library style though 🤔

@wescpy
Copy link
Contributor Author

wescpy commented May 22, 2021

@dandhlee Added a section at the bottom of the top-level README... PTAL when you get a chance. I'm done w/my updates, so feel free to submit or give me perms to merge the PR... thx & have a great wknd!

@dandhlee dandhlee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 22, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 22, 2021
@dandhlee
Copy link
Contributor

Have a good weekend! :D

I don't feel qualified enough to touch on a client library for common style, I'll wait for Bu Sun to chime in 😅

@wescpy wescpy requested review from sirtorry and telpirion May 22, 2021 07:36
@wescpy
Copy link
Contributor Author

wescpy commented May 22, 2021

NP Dan! Also added Eric (hi!) and Torry (hi to you too) as managers.

@@ -0,0 +1,3 @@
For a complete sample Python "mini-Google Translate" web app using the [Google Cloud Translation API](https://cloud.google.com/translate), go to <https://github.com/googlecodelabs/cloud-nebulous-serverless-python>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should move this text to the previous file (the top-level README). Placing this README leaves the important information buried within the repo and may be confusing to the customers who find it.

Additionally, I would make sure that you've added a link to your app in the official Translation documentation on CGC.

@telpirion telpirion changed the title connect Python Translate client library to nebulous serverless example docs: connect Python Translate client library to nebulous serverless example May 27, 2021
@telpirion telpirion added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2021
@wescpy
Copy link
Contributor Author

wescpy commented May 28, 2021

Thx all. Can someone merge for me (or give me write perms to do so)?

@dandhlee dandhlee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2021
@dandhlee dandhlee added the automerge Merge the pull request once unit tests and other checks pass. label May 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2986864 into googleapis:master May 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 28, 2021
@wescpy
Copy link
Contributor Author

wescpy commented May 28, 2021

Thx for the merge @dandhlee (and everyone else for the LGTMs)!

gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: translate Issues related to the googleapis/python-translate API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants