This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
test: delete system tests #389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system tests being deleted are handwritten but they are for a client which is fully autogenerated. Issue googleapis/gapic-generator-python#1771 has been filed to evaluate whether these tests can be migrated to `gapic-showcase`, which is closest to where the actual development occurs. We need to delete these tests as it is blocking the migration to `google-cloud-python`, where we are trying to minimize handwritten code.
product-auto-label
bot
added
size: m
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system tests being deleted are handwritten but they are for a client which is fully autogenerated. Issue googleapis/gapic-generator-python#1771 has been filed to evaluate whether these tests can be migrated to
gapic-showcase, which is closest to where the actual development occurs. We need to delete these tests as it is blocking the migration togoogle-cloud-python, where we are trying to minimize handwritten code.