Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

fix: Add shebang to fixup scripts #49

Closed
wants to merge 2 commits into from

Conversation

colincadams
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #48 馃

@colincadams colincadams requested a review from a team as a code owner October 7, 2020 20:03
@google-cla
Copy link

google-cla bot commented Oct 7, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 7, 2020
@colincadams
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 7, 2020
@colincadams colincadams changed the title Add shebang to fixup scripts fix: Add shebang to fixup scripts Oct 7, 2020
@averikitsch averikitsch added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Dec 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2020
@averikitsch averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2020
@averikitsch
Copy link
Contributor

averikitsch commented Dec 7, 2020

@busunkim96 the error is: This project needs at least Sphinx v1.6.3 and therefore cannot be built with this version. This is blocking the other PRs as well.

@busunkim96
Copy link
Contributor

@averikitsch It looks like the templates in this library were a bit old. I regenerated manually in #34 which also fixed the shebang issue.

@busunkim96 busunkim96 closed this Dec 7, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 7, 2020
@colincadams
Copy link
Author

Thanks for fixing this!

@colincadams colincadams deleted the patch-1 branch December 8, 2020 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scripts/fixup*.py run as shell scripts
4 participants