New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation of generation and metageneration to upload functions #98
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 馃摑 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
鈩癸笍 Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! 鈩癸笍 Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one nit, but overall LGTM, thanks for picking this up @HollayHorvath!
size, | ||
num_retries, | ||
predefined_acl, | ||
generation_match, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the name with expected prefix of if_
to follow the API spec?
@@ -1785,6 +1897,10 @@ def _upload_from_file_helper(self, side_effect=None, **kwargs): | |||
content_type = u"font/woff" | |||
client = mock.sentinel.client | |||
predefined_acl = kwargs.get("predefined_acl", None) | |||
generation_match = kwargs.get("generation_match", None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more request, could you add system tests that exercise these new parameters?
Thanks for your support @HollayHorvath, you helped get this ball moving and will have it out in the library soon. @IlyaFaer is taking the work you've done and making necessary changes to get into the library. I'm closing out this PR and continuing the remaining discussions in #111. |
Fixes #16 馃