Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pin six as a required dependency #589

Merged
merged 2 commits into from Sep 16, 2021
Merged

fix: pin six as a required dependency #589

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f006df
fix: pin six as a required dependency
dandhlee Sep 16, 2021
cb8e3f0
chore: pin protobuf for older Python 2.7
dandhlee Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions setup.py
View file
Open in desktop
Expand Up @@ -37,7 +37,9 @@
"google-resumable-media >= 1.3.0, < 2.0dev; python_version<'3.0'",
"google-resumable-media >= 1.3.0, < 3.0dev; python_version>='3.6'",
"requests >= 2.18.0, < 3.0.0dev",
"protobuf < 3.18.0; python_version<'3.0'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be adding an un-pinned protobuf for Python 3.x (to avoid future transitive dep failures):

Suggested change
"protobuf < 3.18.0; python_version<'3.0'",
"protobuf < 3.18.0; python_version<'3.0'",
"protobuf; python_version>='3.6'",

"googleapis-common-protos < 1.53.0; python_version<'3.0'",
"six",
]
extras = {}

Expand Down