Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not append duplicates to user agent string #570

Merged
merged 8 commits into from Sep 2, 2021
Merged

fix: do not append duplicates to user agent string #570

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5083276
fix: do not append duplicates to user agent string
ddelgrosso1 Sep 1, 2021
48e6fee
Update google/cloud/storage/_http.py
ddelgrosso1 Sep 1, 2021
cea0b5a
Merge branch 'main' into user-agent-dupe
ddelgrosso1 Sep 1, 2021
5dd1f9d
linter fix
ddelgrosso1 Sep 1, 2021
762e653
Add test for duplicating user agent
ddelgrosso1 Sep 1, 2021
934d0ce
remove hardcoded version
ddelgrosso1 Sep 1, 2021
e65e6c6
fix linter
ddelgrosso1 Sep 1, 2021
adef243
Merge branch 'main' into user-agent-dupe
tseaver Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion google/cloud/storage/_http.py
View file
Open in desktop
Expand Up @@ -56,7 +56,8 @@ def __init__(self, client, client_info=None, api_endpoint=None):
# TODO: When metrics all use gccl, this should be removed #9552
if self._client_info.user_agent is None: # pragma: no branch
self._client_info.user_agent = ""
self._client_info.user_agent += " gcloud-python/{} ".format(__version__)
if "gcloud-python/{}".format(__version__) not in self._client_info.user_agent:
self._client_info.user_agent += " gcloud-python/{} ".format(__version__)
ddelgrosso1 marked this conversation as resolved.
Show resolved Hide resolved

API_VERSION = "v1"
"""The version of the API, used in building the API call's URL."""
Expand Down