Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revise and rename is_etag_in_json(data) #483

Merged
merged 10 commits into from Jul 9, 2021
Merged

fix: revise and rename is_etag_in_json(data) #483

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d78e84d
fix: handle cases where data is a dict in is_etag_in_json(data)
cojenco Jun 23, 2021
c1d6697
Merge branch 'master' into etag_in_json
cojenco Jun 28, 2021
3a1186d
Merge branch 'master' into etag_in_json
cojenco Jul 3, 2021
73a9802
address comments and accept proposed changes
cojenco Jul 3, 2021
1e59dbe
Merge branch 'master' into etag_in_json
cojenco Jul 8, 2021
6e665ef
revise is_etag_in_json to check dict data
cojenco Jul 8, 2021
7f35d1a
Merge branch 'master' into etag_in_json
cojenco Jul 9, 2021
da23d13
revise docstring wording
cojenco Jul 9, 2021
ba3c16a
revise docstrings
cojenco Jul 9, 2021
af0abb3
rename conditional predicate to is_etag_in_data
cojenco Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/storage/retry.py
View file
Open in desktop
Expand Up @@ -122,7 +122,7 @@ def is_etag_in_json(data):
"""Return True if an etag is contained in the JSON body.

:type data: dict or None
:param data: A dict containing the JSON body. If not passed, returns False.
:param data: A dict representing the JSON body. If not passed, returns False.

Intended for use on calls with relatively short JSON payloads."""
tseaver marked this conversation as resolved.
Show resolved Hide resolved
return data is not None and "etag" in data
Expand Down