New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revise blob.compose query parameters if_generation_match
#454
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a1a66c3
revise blob.compose logic to match API usage
cojenco bd7407a
update tests
cojenco a896eff
update system test
cojenco 5dec505
Merge branch 'master' into obj-compose-retry
cojenco b4363af
address comments
cojenco 87a7411
Merge branch 'master' into obj-compose-retry
tseaver 13e221f
馃 Updates from OwlBot
gcf-owl-bot[bot] 1c1d70d
Merge branch 'master' into obj-compose-retry
tseaver 42be461
revise logic for backwards compatibility
cojenco b94f05c
add tests
cojenco b6ce5ef
revise docstring
cojenco 8526054
Merge main branch
cojenco 3958562
fix test
cojenco 941da79
revise to DeprecationWarning
cojenco 23be964
address comments and revise docstrings
cojenco e2c051c
Merge branch 'master' into obj-compose-retry
cojenco File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend phrasing this something like:
"Note: In a previous version, this argument worked identically to the if_source_generation_match argument. For backwards-compatibility reasons, if a list is passed in, this argument will behave like if_source_generation_match and also issue a DeprecationWarning."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I like this phrasing a lot, thanks!