Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: revise docstrings for generate_signed_url #408

Merged
merged 4 commits into from Apr 19, 2021
Merged

docs: revise docstrings for generate_signed_url #408

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30616fa
Adjusting comment for accuracy
DiegoQueiroz Apr 14, 2021
36e1240
fix: adjusting comment for accuracy
DiegoQueiroz Apr 14, 2021
132a33e
Merge branch 'patch-1' of https://github.com/DiegoQueiroz/python-stor…
DiegoQueiroz Apr 14, 2021
a091972
Merge branch 'master' into patch-1
cojenco Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/storage/_signing.py
View file
Open in desktop
Expand Up @@ -277,7 +277,7 @@ def generate_signed_url_v2(

Assumes ``credentials`` implements the
:class:`google.auth.credentials.Signing` interface. Also assumes
``credentials`` has a ``service_account_email`` property which
``credentials`` has a ``signer_email`` property which
identifies the credentials.

.. note::
Expand Down Expand Up @@ -441,7 +441,7 @@ def generate_signed_url_v4(

Assumes ``credentials`` implements the
:class:`google.auth.credentials.Signing` interface. Also assumes
``credentials`` has a ``service_account_email`` property which
``credentials`` has a ``signer_email`` property which
identifies the credentials.

.. note::
Expand Down