feat: Add encryption_key param to Blob.from_string #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `encryption_key` parameter to Blob.from_string. * Fix several typos and format errors.
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: storage
Signed-off-by: GitHub <noreply@github.com>
cojenco
reviewed
Apr 5, 2021
cojenco
reviewed
Apr 5, 2021
cojenco
requested changes
Apr 5, 2021
There was a problem hiding this comment.
Thanks @harrydrippin for submitting a PR and helping us improve. Please refer to the comments for a few change requests. Feel free to let me know if any questions. Thank you!
* Fix indentation inside `Blob.from_string()`
Co-authored-by: cojenco <59401799+cojenco@users.noreply.github.com>
tseaver
approved these changes
Apr 20, 2021
|
@harrydrippin Thanks for your patch. We've decided to use a getter/setter for encryption key: #409. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several fixes as follows:
encryption_keyparameter to Blob.from_string.Fixes #390 馃