Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly encode bytes for V2 signature #382

Merged
merged 3 commits into from Feb 17, 2021
Merged

fix: correctly encode bytes for V2 signature #382

merged 3 commits into from Feb 17, 2021

Commits on Feb 17, 2021

  1. fix: correctly encode bytes for V2 signature 

    V2 signature was passing a string to the sign_bytes function
instead of bytes. This works fine for most credentials (since
their sign_bytes implementations accept strings) but not for
impersonated credentials. V4 signature encodes the string before
calling sign_bytes, so I do the same here.

We should also look into clarifying the contract for the
sign_bytes interface in the auth library.

Fixes googleapis#373
    @tritone
    tritone committed Feb 17, 2021
    Copy the full SHA
    372a4d9 View commit details
    Browse the repository at this point in the history

  2. fix py2 failure

    @tritone
    tritone committed Feb 17, 2021
    Copy the full SHA
    6248a14 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into signed-url-fix

    @tritone
    tritone committed Feb 17, 2021
    Copy the full SHA
    7fd92c1 View commit details
    Browse the repository at this point in the history