Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fall back to 'charset' of 'content_type' in 'download_as_text' #326

Merged
merged 3 commits into from Nov 30, 2020
Merged

fix: fall back to 'charset' of 'content_type' in 'download_as_text' #326

merged 3 commits into from Nov 30, 2020

Commits on Nov 24, 2020

  1. fix: fall back to 'charset' of 'content_type' in 'download_as_text' 

    Explicit 'encoding' overrides the fallback.

Use the 'charset' param of 'content_type', rather than 'content_encoding',
which isn't going to be a Unicode -> bytes encoding.

Closes #319.
    @tseaver
    tseaver committed Nov 24, 2020
    Copy the full SHA
    d4ee030 View commit details
    Browse the repository at this point in the history

  2. chore: rewrap long param descriptions 

    Improve in-source readability.
    @tseaver
    tseaver committed Nov 24, 2020
    Copy the full SHA
    0f434fb View commit details
    Browse the repository at this point in the history

  3. tests: coverage

    @tseaver
    tseaver committed Nov 24, 2020
    Copy the full SHA
    3801122 View commit details
    Browse the repository at this point in the history