New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storage): add projection parameter to blob.reload method #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a system test. Otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, have one last nit.
google/cloud/storage/_helpers.py
Outdated
@@ -135,6 +135,7 @@ def _query_params(self): | |||
|
|||
def reload( | |||
self, | |||
projection="noAcl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this parameter after the client parameter?
…pis#146) * fix(storage): add projection parameter to blob.reload method * fix(storage): add system test * fix(storage): nit
…pis#146) * fix(storage): add projection parameter to blob.reload method * fix(storage): add system test * fix(storage): nit
…pis#146) * fix(storage): add projection parameter to blob.reload method * fix(storage): add system test * fix(storage): nit
Fixes #136