Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getters and setters for encryption_key and kms_key_name #409

Merged
merged 5 commits into from Apr 20, 2021

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Apr 14, 2021

Fixes for Blob:

  • add getters and setters for attributes encryption_key and kms_key_name
  • revise docstring descriptions and formatting

Fixes #390 🦕

@cojenco cojenco requested a review from a team April 14, 2021 19:03
@cojenco cojenco requested a review from a team as a code owner April 14, 2021 19:03
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Apr 14, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2021
@tseaver tseaver changed the title fix: add getters and setters for encryption_key and kms_key_name feat: add getters and setters for encryption_key and kms_key_name Apr 20, 2021
@tseaver
Copy link
Contributor

tseaver commented Apr 20, 2021

Note that this is a new feature, not a bugfix. I updated the PR title to reflect that.

@cojenco cojenco merged commit 2adfb59 into master Apr 20, 2021
@cojenco cojenco deleted the setter-390 branch April 20, 2021 18:33
cojenco added a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…ogleapis#409)

* fix: add getters and setters for attributes encryption_key and kms_key_name

* fix docstring formatting

* revise docstring

Co-authored-by: Tres Seaver <tseaver@palladion.com>
cojenco added a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…ogleapis#409)

* fix: add getters and setters for attributes encryption_key and kms_key_name

* fix docstring formatting

* revise docstring

Co-authored-by: Tres Seaver <tseaver@palladion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add encryption_key param to Blob.from_string
2 participants