Skip to content

Commit

Permalink
tests: pin g-c-kms to un-break systests (#232)
Browse files Browse the repository at this point in the history
See: #226
  • Loading branch information
tseaver committed Aug 10, 2020
1 parent e1f91fc commit e8a8638
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
2 changes: 1 addition & 1 deletion noxfile.py
Expand Up @@ -125,7 +125,7 @@ def system(session):
"google-cloud-testutils",
"google-cloud-iam",
"google-cloud-pubsub",
"google-cloud-kms",
"google-cloud-kms < 2.0dev",
)
session.install("-e", ".")

Expand Down
3 changes: 2 additions & 1 deletion synth.py
Expand Up @@ -29,7 +29,8 @@
system_test_external_dependencies=[
"google-cloud-iam",
"google-cloud-pubsub",
"google-cloud-kms",
# See: https://github.com/googleapis/python-storage/issues/226
"google-cloud-kms < 2.0dev",
],
)
s.move(
Expand Down
8 changes: 0 additions & 8 deletions tests/system/test_system.py
Expand Up @@ -1829,14 +1829,6 @@ def test_access_to_public_bucket(self):
retry_429_503(blob.download_to_file)(stream)


_KMS_2_0_BREAKAGE_MESSAGE = """\
KMS 2.0.0 incompatible with our test setup.
See https://github.com/googleapis/python-storage/issues/226
"""


@unittest.skipIf(six.PY3, reason=_KMS_2_0_BREAKAGE_MESSAGE)
class TestKMSIntegration(TestStorageFiles):

FILENAMES = ("file01.txt",)
Expand Down

0 comments on commit e8a8638

Please sign in to comment.