Skip to content

Commit

Permalink
chore: unbundle renovate reports (#575)
Browse files Browse the repository at this point in the history
We need to be able to close those for the Python 2.7 requirements,
while allowing through the normal Python 3 reports.

Closes #578.

Use an '@google.com' principal for system test w/ UBLA.

Closes #577.
  • Loading branch information
tseaver committed Sep 2, 2021
1 parent 08ee4a7 commit d0f45e9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
8 changes: 4 additions & 4 deletions owlbot.py
Expand Up @@ -14,8 +14,6 @@

"""This script is used to synthesize generated parts of this library."""

import re

import synthtool as s
from synthtool import gcp
from synthtool.languages import python
Expand All @@ -34,15 +32,17 @@
# See: https://github.com/googleapis/python-storage/issues/226
"google-cloud-kms < 2.0dev",
],
intersphinx_dependencies = {
intersphinx_dependencies={
"requests": "https://docs.python-requests.org/en/master/"
},
)

s.move(
templated_files, excludes=[
templated_files,
excludes=[
"docs/multiprocessing.rst",
"noxfile.py",
"renovate.json", # do not bundle reports
"CONTRIBUTING.rst",
],
)
Expand Down
1 change: 0 additions & 1 deletion renovate.json
@@ -1,7 +1,6 @@
{
"extends": [
"config:base",
"group:all",
":preserveSemverRanges",
":disableDependencyDashboard"
],
Expand Down
4 changes: 2 additions & 2 deletions tests/system/test_bucket.py
Expand Up @@ -706,7 +706,7 @@ def test_new_bucket_w_ubla(
bucket_acl.reload()

bucket_acl.loaded = True # Fake that we somehow loaded the ACL
bucket_acl.all().grant_read()
bucket_acl.group("cloud-developer-relations@google.com").grant_read()
with pytest.raises(exceptions.BadRequest):
bucket_acl.save()

Expand All @@ -724,7 +724,7 @@ def test_new_bucket_w_ubla(
blob_acl.reload()

blob_acl.loaded = True # Fake that we somehow loaded the ACL
blob_acl.all().grant_read()
blob_acl.group("cloud-developer-relations@google.com").grant_read()
with pytest.raises(exceptions.BadRequest):
blob_acl.save()

Expand Down

0 comments on commit d0f45e9

Please sign in to comment.