This repository has been archived by the owner on Apr 20, 2024. It is now read-only.
fix: deleted a line duplicating the call to the recognizer #83
Merged
b-loved-dreamer
merged 12 commits into
googleapis:master
from
b-loved-dreamer:fixduplicatecalling
Nov 16, 2020
Merged
fix: deleted a line duplicating the call to the recognizer #83
b-loved-dreamer
merged 12 commits into
googleapis:master
from
b-loved-dreamer:fixduplicatecalling
Nov 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-loved-dreamer
requested review from
sirtorry,
telpirion and
a team
as code owners
October 28, 2020 17:05
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Oct 28, 2020
…mitations on local files for the long_running_recognize
…mitations on local files for the long_running_recognize
…ime limitations on local files for the long_running_recognize
… time limitations on local files for the long_running_recognize
tseaver
previously requested changes
Oct 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reduce the contents of this PR to those relevant to the changes you want to make. We require that submitted code pass our linter, including having no changes when black
is run using our configuration.
pick f510e8f chore: I updated the comments on the transcribe_async file to reflect time limitations on local files for the long_running_recognize
b-loved-dreamer
force-pushed
the
fixduplicatecalling
branch
from
October 28, 2020 20:27
6780b1a
to
dc110ba
Compare
telpirion
reviewed
Oct 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending all reviewer changes.
sirtorry
approved these changes
Nov 3, 2020
telpirion
dismissed
tseaver’s stale review
November 16, 2020 22:37
Reviewer has not responded to request for re-review.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing this change to fix a duplicate issue