Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove database_version_time param from test_instance_list_backups #609

Merged
merged 1 commit into from Oct 4, 2021
Merged

fix: remove database_version_time param from test_instance_list_backups #609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 2 additions & 14 deletions tests/system/test_backup_api.py
View file
Open in desktop
Expand Up @@ -383,11 +383,7 @@ def test_multi_create_cancel_update_error_restore_errors(


def test_instance_list_backups(
shared_instance,
shared_database,
second_database,
database_version_time,
backups_to_delete,
shared_instance, shared_database, second_database, backups_to_delete,
):
# Remove un-scrubbed backups FBO count below.
_helpers.scrub_instance_backups(shared_instance)
Expand All @@ -400,16 +396,8 @@ def test_instance_list_backups(
)
expire_time_1_stamp = expire_time_1.strftime("%Y-%m-%dT%H:%M:%S.%fZ")

# Backup tests are failing because of timeout. As a temporary fix
# we are increasing db version time to current time.
# Read more: https://github.com/googleapis/python-spanner/issues/496
database_version_time = datetime.datetime.now(datetime.timezone.utc)

backup1 = shared_instance.backup(
backup_id_1,
database=shared_database,
expire_time=expire_time_1,
version_time=database_version_time,
backup_id_1, database=shared_database, expire_time=expire_time_1,
)

expire_time_2 = datetime.datetime.now(datetime.timezone.utc) + datetime.timedelta(
Expand Down