tests: add backup/restore timeouts; reduce backup creation count #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
google-cla
bot
added
the
cla: yes
larkee
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tseaver
approved these changes
Aug 18, 2021
tseaver
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
larkee
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tseaver
added
automerge
yoshi-kokoro
removed
the
kokoro:force-run
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
larkee
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
larkee
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
larkee
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
larkee
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
larkee
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the backup creation and database restores do not specify a timeout. This can cause the system tests to run for ~2 hours. Adding timeouts will help to combat this. Additionally, reducing the number of backups created will reduce the flakiness of tests as there is less opportunity for a backup to stall and break other tests.