Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: avoid using real credentials unit tests #432

Merged
merged 2 commits into from Jul 29, 2021
Merged

tests: avoid using real credentials unit tests #432

merged 2 commits into from Jul 29, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 28, 2021

Closes #431.

@tseaver tseaver requested a review from larkee July 28, 2021 21:52
@tseaver tseaver requested a review from a team as a code owner July 28, 2021 21:52
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jul 28, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 28, 2021
@tseaver
Copy link
Contributor Author

tseaver commented Jul 28, 2021 •
edited

Unit tests /w [trace] will fail for Python > 3.6 until #429 is merged.

Rebased to master after merge of #429.

@larkee larkee merged commit 9c529f3 into master Jul 29, 2021
@larkee larkee deleted the 431-unittests-avoid-env-credentials branch July 29, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit tests should not require credentials from environment
2 participants
@tseaver @larkee