Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): add processing_units to Instance resource #364

Merged
merged 2 commits into from Jun 17, 2021
Merged

feat(spanner): add processing_units to Instance resource #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d006c0e
feat(spanner): add processing_units to Instance resource
gcf-owl-bot[bot] Jun 14, 2021
674c015
🦉 Updates from OwlBot
gcf-owl-bot[bot] Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions google/cloud/spanner_admin_instance_v1/types/spanner_instance_admin.py
View file
Open in desktop
Expand Up @@ -128,6 +128,11 @@ class Instance(proto.Message):
See `the
documentation <https://cloud.google.com/spanner/docs/instances#node_count>`__
for more information about nodes.
processing_units (int):
The number of processing units allocated to this instance.
At most one of processing_units or node_count should be
present in the message. This may be zero in API responses
for instances that are not yet in state ``READY``.
state (google.cloud.spanner_admin_instance_v1.types.Instance.State):
Output only. The current instance state. For
[CreateInstance][google.spanner.admin.instance.v1.InstanceAdmin.CreateInstance],
Expand Down Expand Up @@ -177,6 +182,7 @@ class State(proto.Enum):
config = proto.Field(proto.STRING, number=2,)
display_name = proto.Field(proto.STRING, number=3,)
node_count = proto.Field(proto.INT32, number=5,)
processing_units = proto.Field(proto.INT32, number=9,)
state = proto.Field(proto.ENUM, number=6, enum=State,)
labels = proto.MapField(proto.STRING, proto.STRING, number=7,)
endpoint_uris = proto.RepeatedField(proto.STRING, number=8,)
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/gapic/spanner_admin_instance_v1/test_instance_admin.py
View file
Open in desktop
Expand Up @@ -1488,6 +1488,7 @@ def test_get_instance(
config="config_value",
display_name="display_name_value",
node_count=1070,
processing_units=1743,
state=spanner_instance_admin.Instance.State.CREATING,
endpoint_uris=["endpoint_uris_value"],
)
Expand All @@ -1504,6 +1505,7 @@ def test_get_instance(
assert response.config == "config_value"
assert response.display_name == "display_name_value"
assert response.node_count == 1070
assert response.processing_units == 1743
assert response.state == spanner_instance_admin.Instance.State.CREATING
assert response.endpoint_uris == ["endpoint_uris_value"]

Expand Down Expand Up @@ -1549,6 +1551,7 @@ async def test_get_instance_async(
config="config_value",
display_name="display_name_value",
node_count=1070,
processing_units=1743,
state=spanner_instance_admin.Instance.State.CREATING,
endpoint_uris=["endpoint_uris_value"],
)
Expand All @@ -1566,6 +1569,7 @@ async def test_get_instance_async(
assert response.config == "config_value"
assert response.display_name == "display_name_value"
assert response.node_count == 1070
assert response.processing_units == 1743
assert response.state == spanner_instance_admin.Instance.State.CREATING
assert response.endpoint_uris == ["endpoint_uris_value"]

Expand Down