Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove erroneous timeouts for batch_create_session calls #18

Merged
merged 4 commits into from Feb 19, 2020
Merged

fix: remove erroneous timeouts for batch_create_session calls #18

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c05acf1
fix: remove erroneous timeouts for batch_create_session calls in sess…
larkee Feb 12, 2020
0dcd111
Merge branch 'master' into remove-erroneous-timeouts
larkee Feb 18, 2020
8a02369
blacken
larkee Feb 18, 2020
d4f5cff
Merge branch 'master' into remove-erroneous-timeouts
larkee Feb 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 2 additions & 8 deletions google/cloud/spanner_v1/pool.py
View file
Open in desktop
Expand Up @@ -171,10 +171,7 @@ def bind(self, database):

while not self._sessions.full():
resp = api.batch_create_sessions(
database.name,
self.size - self._sessions.qsize(),
timeout=self.default_timeout,
larkee marked this conversation as resolved.
Show resolved Hide resolved
metadata=metadata,
database.name, self.size - self._sessions.qsize(), metadata=metadata
)
for session_pb in resp.session:
session = self._new_session()
Expand Down Expand Up @@ -365,10 +362,7 @@ def bind(self, database):

while created_session_count < self.size:
resp = api.batch_create_sessions(
database.name,
self.size - created_session_count,
timeout=self.default_timeout,
metadata=metadata,
database.name, self.size - created_session_count, metadata=metadata
)
for session_pb in resp.session:
session = self._new_session()
Expand Down