Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add support for Proto Columns #1084

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

harshachinta
Copy link
Contributor

@harshachinta harshachinta commented Jan 29, 2024

This PR adds support for proto columns feature.

* feat: adding proto autogenerated code changes for proto column feature

* feat: add implementation for Proto columns DDL

* feat: add implementation for Proto columns DML

* feat: add implementation for Proto columns DQL

* feat: add NoneType check during Proto deserialization

* feat: add code changes for Proto DDL support

* feat: add required proto files to execute samples and tests

* feat: add sample snippets for Proto columns DDL

* feat: add tests for proto columns ddl, dml, dql snippets

* feat: code refactoring

* feat: remove staging endpoint from snippets.py

* feat: comment refactor

* feat: add license file

* feat: update proto column data in insertion sample

* feat: move column_info argument to the end to avoid breaking code
* feat: add integration tests for Proto Columns

* feat: add unit tests for Proto Columns

* feat: update tests to add column_info argument at end

* feat: remove deepcopy during deserialization of proto message

* feat: tests refactoring

* feat: integration tests refactoring

* feat: samples and sample tests refactoring

* feat: lint tests folder

* feat:lint samples directory

* feat: stop running emulator with proto ddl commands

* feat: close the file after reading

* feat: update protobuf version lower bound to >3.20 to check proto message compatibility

* feat: update setup for snippets_tests.py file

* feat: add integration tests

* feat: remove duplicate integration tests

* feat: add proto_descriptor parameter to required tests

* feat: add compatibility tests between Proto message, Bytes and Proto Enum, Int64

* feat: add index tests for proto columns

* feat: replace duplicates with sample data

* feat: update protobuf lower bound version in setup.py file to add support for proto messages and enum

* feat: lint fixes

* feat: lint fix

* feat: tests refactoring

* feat: change comment from dml to dql for read

* feat: tests refactoring for update db operation
Copy link

snippet-bot bot commented Jan 29, 2024

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/python-spanner API. labels Jan 29, 2024
@harshachinta harshachinta removed the request for review from nicain May 3, 2024 08:28
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants