New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Point In Time Recovery (PITR) #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkee
added
the
api: spanner
Issues related to the googleapis/python-spanner API.
label
Oct 7, 2020
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Oct 7, 2020
larkee
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Oct 7, 2020
larkee
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 8, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 8, 2020
thiagotnunes
approved these changes
Oct 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
larkee
force-pushed
the
pitr-support
branch
2 times, most recently
from
November 24, 2020 08:33
fade85a
to
b41da25
Compare
LGTM |
thiagotnunes
changed the title
feat: add support for PITR-lite
feat: Point In Time Recovery (PITR)
Feb 4, 2021
larkee
changed the title
feat: Point In Time Recovery (PITR)
feat: add support for Point In Time Recovery (PITR)
Feb 4, 2021
* Backup changes * Basic tests * Add system tests * Fix system tests * Add retention period to backup systests
* Remove unnecessary retention period setting * Fix systests
* Remove unnecessary retention period setting * Fix systests * Review changes
larkee
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Feb 5, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Feb 5, 2021
larkee
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Feb 22, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 23, 2021
This PR fixes the assertion to use `metadata.backup_info.version_time` instead of `metadata.backup_info.create_time`. It looks it was passing before the backend correctly supported it and I forgot to re-run the tests before merging #148 (whoops!) and so it is currently failing and preventing #205 from being merged: https://source.cloud.google.com/results/invocations/8f0f5dab-1b35-4ce3-bb72-0ce9e79ab89d/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-spanner%2Fpresubmit%2Fpresubmit/log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/python-spanner API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for PITR.
With this functionality users will be able to:
Creating a backup with a specific version time is shown below: