Skip to content

Commit

Permalink
chore: s.remove_staging_dirs() should only be called once (#356)
Browse files Browse the repository at this point in the history
There is [an issue](https://github.com/googleapis/python-spanner/blob/master/owlbot.py#L30) in the `owlbot.py` file added in #319 in that [s.remove_staging_dirs()](https://github.com/googleapis/synthtool/blob/master/synthtool/transforms.py#L309) should only be called once after all the files are copied over.  [get_staging_dirs()](https://github.com/googleapis/synthtool/blob/master/synthtool/transforms.py#L280) will only return staging directories that exist.
  • Loading branch information
parthea committed Jun 1, 2021
1 parent 36df202 commit f58d2c3
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions owlbot.py
Expand Up @@ -27,14 +27,10 @@
if library.parent.absolute() == "spanner":
s.move(library, excludes=["google/cloud/spanner/**", "*.*", "docs/index.rst", "google/cloud/spanner_v1/__init__.py"])

s.remove_staging_dirs()

for library in s.get_staging_dirs(spanner_admin_instance_default_version):
if library.parent.absolute() == "spanner_admin_instance":
s.move(library, excludes=["google/cloud/spanner_admin_instance/**", "*.*", "docs/index.rst"])

s.remove_staging_dirs()

for library in s.get_staging_dirs(spanner_admin_database_default_version):
if library.parent.absolute() == "spanner_admin_database":
s.move(library, excludes=["google/cloud/spanner_admin_database/**", "*.*", "docs/index.rst"])
Expand Down

0 comments on commit f58d2c3

Please sign in to comment.