Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: allow merging pull requests that are not up to date #374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

olavloite
Copy link
Contributor

Allow pull requests that are not up to date with main to be merged, as we otherwise have re-run all tests for each PR before merging, which takes too long.

Allow pull requests that are not up to date with main to be merged, as we otherwise have re-run all tests for each PR before merging, which takes too long.
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Nov 14, 2023
Copy link
Contributor

@harshachinta harshachinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olavloite
Instead of relaxing strict status check altogether, should we consider removing the long running checks from requiredStatusCheckContexts? This way atleast the basic checks can be validated?

@parthea
Copy link
Contributor

parthea commented Nov 14, 2023

@olavloite Please could you file bugs for the failing presubmits?

@olavloite
Copy link
Contributor Author

@olavloite Instead of relaxing strict status check altogether, should we consider removing the long running checks from requiredStatusCheckContexts? This way atleast the basic checks can be validated?

Note that this change does not mean that the required checks do not need to pass. Only that the branch does not need to be up to date with all changes in main. That makes it easier to run the tests for multiple (dependency) pull requests in parallel, and then merge them all. That means that there is still a small possibility that different dependencies break each other, but that will then show up in the build of the main branch (and in any release pull request).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants