Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tweak table dropping mechanism #28

Merged
merged 5 commits into from Mar 18, 2021
Merged

feat: tweak table dropping mechanism #28

merged 5 commits into from Mar 18, 2021

Conversation

IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Mar 16, 2021 •
edited

The PR requires changes of the #277 to be merged first.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2021
@IlyaFaer
Copy link
Contributor Author

@larkee, I've been using this method from the beginning. In fact most of the testing cleanups will fail without these changes - meaning all the screenshots with test logs, I've been sending you during the last month, were based on these changes.

larkee
larkee reviewed Mar 16, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I would prefer a couple unit tests for this.

Also, the compliance_test is failing to run:

INTERNALERROR> sqlalchemy.exc.ArgumentError: Could not parse rfc1738 URL from string 'None'

Any ideas on what is causing this break?

@larkee larkee mentioned this pull request Mar 16, 2021
Merged
larkee
larkee reviewed Mar 17, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The break was caused by #25 but has now been resolved.

google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py Show resolved Hide resolved
@IlyaFaer IlyaFaer merged commit 7db3af4 into main Mar 18, 2021
@IlyaFaer IlyaFaer deleted the drop_table branch March 18, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IlyaFaer @larkee