-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: array columns reflection #119
Merged
Merged
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,6 +49,7 @@ | |
from sqlalchemy.ext.declarative import declarative_base | ||
from sqlalchemy.orm import relation | ||
from sqlalchemy.orm import Session | ||
from sqlalchemy.types import ARRAY | ||
from sqlalchemy.types import Integer | ||
from sqlalchemy.types import Numeric | ||
from sqlalchemy.types import Text | ||
|
@@ -901,6 +902,33 @@ def test_binary_reflection(self): | |
assert isinstance(typ, LargeBinary) | ||
eq_(typ.length, 20) | ||
|
||
@testing.requires.table_reflection | ||
def test_array_reflection(self): | ||
"""Check array columns reflection.""" | ||
orig_meta = self.metadata | ||
|
||
str_array = ARRAY(String(16)) | ||
int_array = ARRAY(Integer) | ||
Table( | ||
"arrays_test", | ||
orig_meta, | ||
Column("id", Integer, primary_key=True), | ||
Column("str_array", str_array), | ||
Column("int_array", int_array), | ||
) | ||
orig_meta.create_all() | ||
|
||
# autoload the table and check its columns reflection | ||
tab = Table("arrays_test", orig_meta, autoload=True) | ||
col_types = [col.type for col in tab.columns] | ||
for type_ in ( | ||
str_array, | ||
int_array, | ||
): | ||
assert type_ in col_types | ||
|
||
tab.drop() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Running test for two types: simple integer and more complex string with size. |
||
|
||
|
||
class CompositeKeyReflectionTest(_CompositeKeyReflectionTest): | ||
@testing.requires.foreign_key_constraint_reflection | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array column string representation actually has two types, for example:
ARRAY<STRING(MAX)>
If we see it's an array, we strip its definition and run
_designate_type()
method for the inner type.