New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: executemany() should return every executed query result #551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments about setting the result set and row count.
Chaining the result sets from each execute
call looks sane to me, but FWIW PEP 249 makes it sound like this isn't the typical use:
Use of this method for an operation which produces one or more result sets constitutes undefined behavior, and the implementation is permitted (but not required) to raise an exception when it detects that a result set has been created by an invocation of the operation.
executemany
shouldn't allow DDL right? I ask because it looks like execute
queues up DDL statements without executing them and only calls update_ddl
on the next non-DDL call. Also sqlite disallows this.
Co-authored-by: Chris Kleinknecht <libc@google.com>
@c24t, okay, fixed. |
Closed in favor of googleapis/python-spanner#181. |
Fixes: #518