Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding missing docstrings for functions & classes #549

Closed
wants to merge 60 commits into from
Closed

feat: adding missing docstrings for functions & classes #549

wants to merge 60 commits into from

Conversation

tina80lvl
Copy link
Contributor

Added descriptions for classes' and functions' functionalities and arguments.

larkee and others added 30 commits May 26, 2020 14:09
@larkee
feat: release 2.2a0 (googleapis#457)
11222db 
Release-As: 2.2.a0

Co-authored-by: larkee <larkee@users.noreply.github.com>
@mf2199
feat: [WIP] The first stage of nox implementation (googleapis#468)
5551b58
feat: refactor connect() function, cover it with unit tests (googleap…
bfde221 
…is#462)
@mf2199
feat: Stage 2 of nox implementation - adding docs target (googlea…
e017901 
…pis#473)
@c24t
fix: Fix black, isort compatibility (googleapis#469)
144bdc2
@mf2199
feat: Stage 3-4 of nox implementation - adding auto-format targets (g…
7a1f6a6 
…oogleapis#478)
@mf2199
feat: Stage 5 of nox implementation - adding coverage targets (goog…
acd9209 
…leapis#479)
feat: cursor must detect if the parent connection is closed (googleap…
6028f88 
…is#463)
@mf2199
feat: Stage 6 of nox implementation - enabling system tests (google…
94ba284 
…apis#480)

Add googleapis/python-test-utils and system test stub
@mf2199
chore: Code refactoring to follow common Google API scheme - Stage I (g…
59eb432 
…oogleapis#487)
@c24t
chore: release 2.2a1 (googleapis#499)
048566c 
Release-As: 2.2.a1
Merge branch 'master' of https://github.com/googleapis/python-spanner…
f5719f8 
…-django
@tina80lvl
fix: Couple of tests are permanently broken while running locally
2c0c0a2
@tina80lvl
fix: offset for current timezone
05bf7dc
@tina80lvl
clean: whitespace
31185df
@tina80lvl
fix: localtime->gmtime
bd605a5
@tina80lvl
fix: gmtime->localtime
23f87ad
@tina80lvl
refactor
216a92b
@tina80lvl
docs: utils.py
3b34162
@tina80lvl
docs: version.py`
d5ba00c
@tina80lvl
refactor
ccfb6ce
@mf2199
Merge pull request #5 from q-logic/fix-472
9526cc2 
fix: Couple of tests are permanently broken while running locally
@mf2199
Merge remote-tracking branch 'upstream/master'
a921666 
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@tina80lvl
docs: parser.py
60fd3fb
@tina80lvl
refactor
d86e8a1
@tina80lvl
docs: parse_utils.py
325abb9
@tina80lvl
docs: cursor.py
539b3dd
@tina80lvl
docs: connection.py
5ce0fa9
@tina80lvl
refactor
a9eb4a6
@tina80lvl
conflict
bbb3378
@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 8, 2020
@google-cla
Copy link

google-cla bot commented Nov 8, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@c24t c24t added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 12, 2020
@google-cla
Copy link

google-cla bot commented Nov 12, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 12, 2020
@google-cla
Copy link

google-cla bot commented Nov 12, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@c24t c24t added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 12, 2020
c24t
c24t approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but note that these changes will have to get picked onto python-spanner now that googleapis/python-spanner#160 is merged.

@google-cla
Copy link

google-cla bot commented Nov 23, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 23, 2020
@mf2199 mf2199 added api: spanner Issues related to the googleapis/python-spanner-django API. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 23, 2020
@mf2199
Copy link
Contributor

mf2199 commented Nov 23, 2020

@googlebot I consent.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 23, 2020
@google-cla
Copy link

google-cla bot commented Nov 23, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Dec 7, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@tina80lvl tina80lvl mentioned this pull request Dec 10, 2020
Merged
@AVaksman AVaksman closed this Dec 10, 2020
@AVaksman
Copy link
Contributor

The functionality was moved to https://github.com/googleapis/python-spanner repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c24t c24t c24t approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tina80lvl @mf2199 @c24t @AVaksman @yoshi-kokoro @larkee