Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support aborted transactions internal retry #544
feat: support aborted transactions internal retry #544
Changes from 1 commit
50580b4
481db2a
313e16d
3a7537c
4edf6c1
f87129a
49e17be
a8158b3
ccf5385
a537628
0b1a641
0e2ca3e
a4ffab5
fc890c2
d204836
9ea2a01
7e70d86
870e170
450b91b
578eaa2
59d597a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these tests are still here? They were copied into
unit
directory, so I suppose they should be erased from this directory?!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. Looks like this (and
test_connect
) weren't moved in #532?https://github.com/q-logic/python-spanner-django/blob/41abaebb6f2e0b1cf16704aa1e394acc5a47e68b/tests/spanner_dbapi/test_connection.py
The test files weren't exactly copied, #532 changed them and added some new tests. E.g. the version on master now doesn't include
test_transaction_autocommit_warnings
.@mf2199 can you confirm that you meant to change/remove these tests before removing
tests/spanner_dbapi
in this PR?