feat: added test cases

noxfile.py

@@ -66,7 +66,12 @@ def lint_setup_py(session):
 def default(session):
     # Install all test dependencies, then install this package in-place.
     session.install(
-        "django~=2.2", "mock", "mock-import", "pytest", "pytest-cov"
+        "django~=2.2",
+        "mock",
+        "mock-import",
+        "pytest",
+        "pytest-cov",
+        "coverage",
     )
     session.install("-e", ".")
 
@@ -79,7 +84,7 @@ def default(session):
         "--cov-append",
         "--cov-config=.coveragerc",
         "--cov-report=",
-        "--cov-fail-under=20",
+        "--cov-fail-under=70",
         os.path.join("tests", "unit"),
         *session.posargs
     )

tests/settings.py

@@ -0,0 +1,46 @@
+# Copyright 2021 Google LLC
+#
+# Use of this source code is governed by a BSD-style
+# license that can be found in the LICENSE file or at
+# https://developers.google.com/open-source/licenses/bsd
+
+DEBUG = True
+USE_TZ = True
+
+INSTALLED_APPS = [
+    "django_spanner",  # Must be the first entry
+    "django.contrib.contenttypes",
+    "django.contrib.auth",
+    "django.contrib.sites",
+    "django.contrib.sessions",
+    "django.contrib.messages",
+    "django.contrib.staticfiles",
+    "tests",
+]
+
+TIME_ZONE = "UTC"
+
+DATABASES = {
+    "default": {
+        "ENGINE": "django_spanner",
+        "PROJECT": "emulator-local",
+        "INSTANCE": "django-test-instance",
+        "NAME": "django-test-db",
+    }
+}
+SECRET_KEY = "spanner emulator secret key"
+
+PASSWORD_HASHERS = [
+    "django.contrib.auth.hashers.MD5PasswordHasher",
+]
+
+SITE_ID = 1
+
+CONN_MAX_AGE = 60
+
+ENGINE = "django_spanner"
+PROJECT = "emulator-local"
+INSTANCE = "django-test-instance"
+NAME = "django-test-db"
+OPTIONS = {}
+AUTOCOMMIT = True

tests/unit/django_spanner/models.py

@@ -0,0 +1,67 @@
+# Copyright 2021 Google LLC
+#
+# Use of this source code is governed by a BSD-style
+# license that can be found in the LICENSE file or at
+# https://developers.google.com/open-source/licenses/bsd
+"""
+Different models used for testing django-spanner code.
+"""
+import os
+from django.db import models
+import django
+
+# Load django settings before loading django models.
+os.environ["DJANGO_SETTINGS_MODULE"] = "tests.settings"
+django.setup()
+
+
+# Register transformations for model fields.
+class UpperCase(models.Transform):
+    lookup_name = "upper"
+    function = "UPPER"
+    bilateral = True
+
+
+models.CharField.register_lookup(UpperCase)
+models.TextField.register_lookup(UpperCase)
+
+
+# Models
+class ModelDecimalField(models.Model):
+    field = models.DecimalField()
+
+
+class ModelCharField(models.Model):
+    field = models.CharField()
+
+
+class Item(models.Model):
+    item_id = models.IntegerField()
+    name = models.CharField(max_length=10)
+    created = models.DateTimeField()
+    modified = models.DateTimeField(blank=True, null=True)
+
+    class Meta:
+        ordering = ["name"]
+
+
+class Number(models.Model):
+    num = models.IntegerField()
+    decimal_num = models.DecimalField(max_digits=5, decimal_places=2)
+    item = models.ForeignKey(Item, models.CASCADE)
+
+
+class Author(models.Model):
+    name = models.CharField(max_length=40)
+    last_name = models.CharField(max_length=40)
+    num = models.IntegerField(unique=True)
+    created = models.DateTimeField()
+    modified = models.DateTimeField(blank=True, null=True)
+
+
+class Report(models.Model):
+    name = models.CharField(max_length=10)
+    creator = models.ForeignKey(Author, models.CASCADE, null=True)
+
+    class Meta:
+        ordering = ["name"]

tests/unit/django_spanner/test_base.py

@@ -4,7 +4,6 @@
 # license that can be found in the LICENSE file or at
 # https://developers.google.com/open-source/licenses/bsd
 
-import sys
 import unittest
 import os
 
@@ -13,9 +12,6 @@
 
 
 @mock_import()
-@unittest.skipIf(
-    sys.version_info < (3, 6), reason="Skipping Python versions <= 3.5"
-)
 class TestBase(unittest.TestCase):
     PROJECT = os.environ["GOOGLE_CLOUD_PROJECT"]
     INSTANCE_ID = "instance_id"
@@ -49,7 +45,7 @@ def test_property_instance(self):
             _ = db_wrapper.instance
             mock_instance.assert_called_once_with(settings_dict["INSTANCE"])
 
-    def test_property__nodb_connection(self):
+    def test_property_nodb_connection(self):
         db_wrapper = self._make_one(None)
         with self.assertRaises(NotImplementedError):
             db_wrapper._nodb_connection()
@@ -86,7 +82,7 @@ def test_create_cursor(self):
         db_wrapper.create_cursor()
         mock_cursor.assert_called_once_with()
 
-    def test__set_autocommit(self):
+    def test_set_autocommit(self):
         db_wrapper = self._make_one(self.settings_dict)
         db_wrapper.connection = mock_connection = mock.MagicMock()
         mock_connection.autocommit = False
@@ -110,7 +106,7 @@ def test_is_usable(self):
         mock_connection.cursor = mock.MagicMock(side_effect=Error)
         self.assertFalse(db_wrapper.is_usable())
 
-    def test__start_transaction_under_autocommit(self):
+    def test_start_transaction_under_autocommit(self):
         db_wrapper = self._make_one(self.settings_dict)
         db_wrapper.connection = mock_connection = mock.MagicMock()
         mock_connection.cursor = mock_cursor = mock.MagicMock()

tests/unit/django_spanner/test_client.py

@@ -4,14 +4,11 @@
 # license that can be found in the LICENSE file or at
 # https://developers.google.com/open-source/licenses/bsd
 
-import sys
 import unittest
 import os
+from google.cloud.spanner_dbapi.exceptions import NotSupportedError
 
 
-@unittest.skipIf(
-    sys.version_info < (3, 6), reason="Skipping Python versions <= 3.5"
-)
 class TestClient(unittest.TestCase):
     PROJECT = os.environ["GOOGLE_CLOUD_PROJECT"]
     INSTANCE_ID = "instance_id"
@@ -36,8 +33,6 @@ def _make_one(self, *args, **kwargs):
         return self._get_target_class()(*args, **kwargs)
 
     def test_runshell(self):
-        from google.cloud.spanner_dbapi.exceptions import NotSupportedError
-
         db_wrapper = self._make_one(self.settings_dict)
 
         with self.assertRaises(NotSupportedError):